Skip to content

Publish GitHub release after release jobs#5468

Merged
clockwork-labs-bot merged 13 commits into
masterfrom
bot/publish-github-release-after-steps
Jul 16, 2026
Merged

Publish GitHub release after release jobs#5468
clockwork-labs-bot merged 13 commits into
masterfrom
bot/publish-github-release-after-steps

Conversation

@clockwork-labs-bot

@clockwork-labs-bot clockwork-labs-bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description of Changes

Adds a final publish-github-release job to the manual release workflow. On non-dry-run releases, it waits for all release jobs to finish successfully or be skipped, then calls cargo-release release github-release.

The new release-tool target verifies the target GitHub release is still a draft, dispatches attach-artifacts.yml using the workflow URL returned by gh workflow run, waits for that artifact workflow to complete, and then publishes the release. If the release is already published, the command exits successfully without re-uploading artifacts.

API and ABI breaking changes

None.

Expected complexity level and risk

  1. Workflow-only release behavior plus a new cargo-release target. The risky part is release sequencing, so the workflow keeps explicit needs checks and the publish logic fails before publication if artifact attachment does not succeed.

Testing

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml")'
  • git diff --check
  • PATH=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin:$PATH cargo check --manifest-path tools/release/Cargo.toml
  • PATH=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin:$PATH cargo run --manifest-path tools/release/Cargo.toml -- release github-release --help
  • actionlint .github/workflows/release.yml was not run because actionlint is not installed locally.

Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Comment thread tools/release/src/main.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
Comment thread tools/release/src/main.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
Comment thread tools/release/src/targets/github_release.rs Outdated
@bfops
bfops requested a review from rekhoff as a code owner July 15, 2026 15:44

@jdetter jdetter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick thing on this - otherwise I have no objections here.

Comment thread tools/release/src/targets/github_release.rs
@clockwork-labs-bot
clockwork-labs-bot added this pull request to the merge queue Jul 16, 2026
Merged via the queue into master with commit 00045f3 Jul 16, 2026
71 of 73 checks passed
@bfops
bfops deleted the bot/publish-github-release-after-steps branch July 16, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants